Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gzip encoding support #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: gzip encoding support #134

wants to merge 2 commits into from

Conversation

TheRTK
Copy link

@TheRTK TheRTK commented Feb 25, 2023

Issue

I faced with the problem that the client with gzip compression when sending a request to gripmock gets an error:

rpc error: code = Unimplemented desc = grpc: Decompressor is not installed for grpc-encoding \"gzip\"

Solution

I added a import with encoding/gzip to the file server.tmpl.
This will not affect requests without gzip. GRPS will use this only if a compressor is used in the request:
https://github.com/grpc/grpc-go/blob/3151e834fa2536844f801bb132c684fbb10364fd/server.go#L1269-#L1280

@TheRTK
feat: gzip support (#1)
5d6ce86 
* gzip support with example and integration test
@TheRTK
fix integration test with gzip
04a2171
@TheRTK TheRTK marked this pull request as ready for review February 25, 2023 18:51
@rez1dent3 rez1dent3 mentioned this pull request Sep 9, 2023
Merged
12 tasks
@rez1dent3 rez1dent3 mentioned this pull request Dec 15, 2023
Merged
@fedemengo
Copy link

@jekiapp can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRTK @fedemengo